The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/rmqctl-mcp-config-instance has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
ee8b2d01f31a1547be4f66a617f9be116ea03b36 / unbridled-41 
<[email protected]>
fix(rmqctl): refuse to emit an MCP snippet that cannot start

`rmqctl mcp config` generates the MCP client snippet a user pastes into their 
own
agent (README "any external agent pointed at the output of `rmqctl mcp config`",
docs/ai-agent-architecture.md: "直接粘 `rmqctl mcp config` 的输出即可"). It treated
--instance-id like the optional --config/--context flags and omitted it when the
flag was not given, exiting 0:

    $ rmqctl mcp config
    
{"mcpServers":{"rocketmq-studio":{"command":"rmqctl","args":["mcp","stdio"]}}}

but `mcp stdio` requires the identifier and never defaults it (decision 7), so 
the
emitted argv exits 1 in the client and the tools silently never appear:

    $ rmqctl mcp stdio
    error [INVALID_ARGUMENT]: --instance-id is required
    hint: Pass the Studio Instance identifier explicitly, e.g. --instance-id 
my-instance; ...
    exit=1

Fail closed instead: without an instance identifier the command reports
INVALID_ARGUMENT and prints no snippet. The with-flag output is byte-identical
(the cross-language golden test against the Studio-generated snippet still 
passes).

Tests (rmqctl/):
cd rmqctl && go test ./cmd/ -run TestMCPConfig
- new TestMCPConfigRequiresInstanceID fails before this change (exit 0 and a
  snippet are produced) and passes after it; it also pins that the flagged form
  still emits the identifier.
- TestMCPConfigEmitsOnlyContextAndConfigReferences now supplies the identifier
  (its subject - no credential leakage, no duplicated context fields - is
  unchanged) and asserts the snippet carries the supplied instance rather than 
an
  invented one.
- `go test ./...` shows only the pre-existing yaml renderer failures owned by
  open PR #5850; gofmt reports no changes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37969631305

With regards,
GitHub Actions via GitBox

Reply via email to