The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/topic-import-per-master has failed. Run started by GitHub user unbridled-41 (triggered by unbridled-41).
Head commit for run: 0d1c3756d1ed16e63d5169ca9fafe07d9240cf4b / unbridled-41 <[email protected]> fix(topic): create an imported topic on the masters that lack it verifyTopicImport answered one boolean for the whole cluster - `found` became true as soon as any master held a matching config - and the caller used it as "nothing to do": boolean physicalExists = importing && verifyTopicImport(admin, brokerAddrs, topicConfig); if (!physicalExists) { for (String addr : brokerAddrs) { admin.createAndUpdateTopicConfig(addr, topicConfig); } } So an import in a cluster where the topic exists on one broker group and not on another wrote nothing at all, marked the row ACTIVE and reported success. That is the normal state after a broker group is added to a cluster: the operator re-imports the exported inventory to propagate the topics, every row exists on the old group, nothing is created on the new one, and with autoCreateTopicEnable (the RocketMQ default) the broker later serves the topic auto-created with factory defaults instead of the imported queues/perm/type. verifyGroupImport had the same shape for consumer groups. Return the masters that do not have a matching config yet and create exactly there; a config that differs still refuses with 409, so "only register, never overwrite" is preserved. Tests (server/): mvn -o -B -ntp test -Dtest='RocketMQAdminClientImplTest' -> Tests run: 82, Failures: 0, Errors: 0. - new importTopicCreatesTheTopicOnTheMastersThatLackItTest and importConsumerGroupCreatesTheGroupOnTheMastersThatLackItTest fail before this change ("Wanted but not invoked: createAndUpdateTopicConfig(\"10.0.0.2:10911\")") and pass after it; each asserts the matching master is not rewritten. - mvn -o -B -ntp test -Dtest='RocketMQMetadataProviderTest,MetadataServiceTest' -> Tests run: 107, Failures: 0, Errors: 0; checkstyle passes. Report URL: https://github.com/apache/rocketmq-dashboard/actions/runs/37975423204 With regards, GitHub Actions via GitBox
