unbridled-41 opened a new issue, #5949:
URL: https://github.com/apache/rocketmq-dashboard/issues/5949
### Studio Version
branch: `rocketmq-studio` @ `7e7aa344` (the revision verified; the branch is
based on it)
deployed as: not required to reproduce
### Runtime Environment
Reproduced with the backend tests (`cd server && mvn -o -B -ntp test
-Dtest='RocketMQAdminClientImplTest'`).
### Connected RocketMQ Cluster
Any cluster; the failure needs an update request that carries a delivery
order type.
### Describe the Bug
`createConsumerGroup` reaches the broker for `consumeMessageOrderly` (commit
#4839: "The create form submits the ordered spelling of the group's delivery
order type, and consumeMessageOrderly is the very flag the group settings
dialog reads and writes"), but `updateConsumerGroup` writes only the retry
limit:
```java
for (Map.Entry<String, SubscriptionGroupConfig> entry : configs.entrySet()) {
SubscriptionGroupConfig config = entry.getValue();
config.setRetryMaxTimes(group.getRetryMaxTimes());
admin.createAndUpdateSubscriptionGroupConfig(entry.getKey(), config);
}
```
`deliveryOrderType` is part of the update request the AI tool contract
advertises (`GroupInput`, and the plan's before/after show the switch), so
asking for ordered consumption returned a successful update while the brokers
kept the previous flag. Ordered consumption on a FIFO topic silently did not
happen, and nothing recorded that the field was dropped.
### Steps to Reproduce
1. Update a group with `{"deliveryOrderType":"MESSAGES_ORDER"}` (REST or the
AI update tool).
2. The response reports success; `examineSubscriptionGroupConfig` still
reports `consumeMessageOrderly=false`.
Red before the fix: `Expecting value to be true but was false`.
### What Did You Expect to See?
The field the plan offered is applied, the way the create path applies it.
### What Did You See Instead?
A successful response for a field that was never written.
### Evidence
- `server/.../provider/apache/RocketMQAdminClientImpl.java`
(`updateConsumerGroup`),
`server/.../ops/ai/tool/contract/group/GroupInput.java`.
- `cd server && mvn -o -B -ntp test
-Dtest='RocketMQAdminClientImplTest#updateConsumerGroupAppliesTheRequestedDeliveryOrderTypeTest'`
- fails before the fix.
### Impact
An operator or agent is told the group now consumes in order while it does
not, on the FIFO topics that require it.
### Acceptance Criteria
- An update carrying a delivery order type applies it to every broker's
`consumeMessageOrderly`, an absent value keeps the broker's own flag, and both
cases have regression tests.
**Corresponding PR:** #ISSUEPR#
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
