unbridled-41 opened a new issue, #6010:
URL: https://github.com/apache/rocketmq-dashboard/issues/6010
### Studio Version
branch: `rocketmq-studio` @ `7e7aa344`
### Runtime Environment
Backend tests: `cd server && mvn -o -B -ntp test
-Dtest='SettingsControllerTest'`.
### Describe the Bug
`docs/api-spec.md` ยง14.7 declares a required request body `{"key": ...}` for
`POST /api/settings/datasources/delete`, but the handler binds only a query
parameter, so a client written against the published contract posts a valid
body, the parameter binds to null, and the service answers 400 "Data source key
is required" without deleting anything.
### Steps to Reproduce
`POST /api/settings/datasources/delete` with `Content-Type:
application/json` and body `{"key":"ds-1"}`: 400.
### What Did You Expect to See?
The data source deleted, as documented.
### What Did You See Instead?
A 400 for a request that matches the spec.
### Impact
The documented request cannot succeed at all.
### Acceptance Criteria
Both the documented body and the query parameter the console sends are
accepted, with a regression test.
**Corresponding PR:** #ISSUEPR#
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
