unbridled-41 commented on PR #5960: URL: https://github.com/apache/rocketmq-dashboard/pull/5960#issuecomment-6090980652
### Follow-up review of this fix: the producer scan had the same hole The fix flagged consumer rows when a broker's subscription-group inventory was unreadable, but the producer side of the same page still swallowed the equivalent failure: `findAllProducerConnections` iterates the brokers, catches a failed `getAllProducerInfo`, logs `Failed to fetch producer connections from broker=…, skipping` and returns the surviving rows unflagged. Every producer that only connects to the unreadable broker is therefore missing from the list while the page claims a complete scan — the same "a missing producer looks like one that is not running" problem, on the Producer tab. Commit `a0720bd4` closes that in this branch (first commit `7b7551e7` untouched, no force-push): - `attemptedBrokers` is now counted once from the discovered topology and compared with the successful reads; when they differ, every returned producer row gets `partial = true`; - the all-brokers-failed 502 is unchanged. New regression test `aFailedProducerTableReadMarksTheProducerRowsPartialTest`: two brokers, one returns a producer table, the other throws `RemotingConnectException`; the surviving row must carry `partial = true`. That flag is what drives the page's banner (`web/src/pages/cluster/clients.tsx:732`) and the CSV `Partial` column. Red/green, both observed locally: ``` # with the flagging block removed cd server && mvn -o -B -ntp test -Dtest='RocketMQClientProviderTest#aFailedProducerTableReadMarksTheProducerRowsPartialTest' Tests run: 1, Failures: 1, Errors: 0, Skipped: 0 <<< FAILURE! (Expecting value to be true but was false) (BUILD FAILURE) # with a0720bd4 cd server && mvn -o -B -ntp test -Dtest='RocketMQClientProviderTest' Tests run: 45, Failures: 0, Errors: 0, Skipped: 0 BUILD SUCCESS ``` Branch `fix/client-scan-partial`, HEAD `a0720bd4` (on top of `7b7551e7`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
