unbridled-41 commented on PR #5973:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/5973#issuecomment-6091124643

   ### Follow-up review of this fix: the docs outside `deploy/` still named the 
shared service
   
   The change moved the compose default and the deploy docs to the NameServer 
container's unique name, but the reader-facing entry points and several 
commands still used `nameserver:9876` — the address this PR's own 
troubleshooting note forbids, because Docker DNS resolves it to multiple A 
records once another stack with a `nameserver` service shares `rocketmq_net`. 
Two commits continue the sweep on this branch (earlier commits untouched, no 
force-push):
   
   **`80e400f9` — the entry points**
   - `README.md` quick start: "Studio reaches the cluster at `nameserver:9876` 
(the backend default)" → the NameServer container's unique name 
`rmq-nameserver:9876`, set by `deploy/docker-compose.yml`, with the reason a 
bare service name is unsafe on that network. `README_zh.md` kept in sync.
   - `deploy/rocketmq/README.md` verification commands: `docker compose exec … 
-n nameserver:9876` → `-n rmq-nameserver:9876` (these silently query whichever 
container the ambiguous name resolves to).
   
   **`2a9765e8` — the remaining occurrences in the deploy skill**
   - the two `mqadmin … -n` verification/edit commands and the four query 
recipes in `.claude/skills/deploy-rocketmq/SKILL.md`, plus the 
`producer`/`consumer` rows that describe what `TraceProducer`/`TraceConsumer` 
now default to (this PR changed those to `rmq-nameserver:9876`);
   - the `接入端点` table's NameServer row.
   
   Left as-is deliberately: the quoted broker log line in the troubleshooting 
note (`TargetHost=nameserver:9876`) is the *symptom* being documented, and the 
`docker compose exec nameserver` service selectors are compose service names, 
not addresses.
   
   Evidence — the doc statement is now verifiable against the rendered stacks:
   
   ```
   cd deploy && docker compose -f docker-compose.yml --env-file .env.example 
config | grep NAMESRV
         STUDIO_ROCKETMQ_NAMESRV_ADDR: rmq-nameserver:9876
   
   cd deploy && docker compose -f rocketmq/docker-compose.yml config | grep 
'container_name: rmq-nameserver'
       container_name: rmq-nameserver
   
   grep -rn "nameserver:9876" README.md README_zh.md deploy/ .claude/ | grep -v 
rmq-nameserver   # only the two intentional remainders
   ```
   
   Docs only: no test or build impact.
   
   Branch `fix/deploy-nameserver-address`, HEAD `2a9765e8` (`80e400f9` on top 
of `3a050016`).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to