unbridled-41 opened a new pull request, #5973:
URL: https://github.com/apache/rocketmq-dashboard/pull/5973

   ### Which Issue(s) This PR Fixes
   Fixes #5972
   ### Problem / Evidence
   - `deploy/docker-compose.yml:89`: `STUDIO_ROCKETMQ_NAMESRV_ADDR: 
${...:-nameserver:9876}` - the Studio server kept the ambiguous name the 
runbook warns about (.claude/skills/deploy-rocketmq/SKILL.md: "配置里一律用唯一容器名 
rmq-nameserver:9876,不要用服务名 nameserver:9876").
   - `deploy/rocketmq/clients/Trace{Producer,Consumer}.java`: the 
`NAMESRV_ADDR` fallbacks defaulted to `nameserver:9876` while the compose 
passes `rmq-nameserver:9876`.
   - `deploy/rocketmq/README.md:18` described `rmq-proxy.json` as pointing at 
`nameserver:9876` while the file says `rmq-nameserver:9876`.
   - `deploy/.env.example` never mentioned `STUDIO_ROCKETMQ_NAMESRV_ADDR`.
   ### Root cause / Fix
   The documented fix was applied to the seven NameServer-facing configs but 
not to these defaults. Align them and document the knob.
   ### Priority and scoring
   **PRIORITY 48** - impact 16/40 (an observed cross-stack misresolution whose 
symptom points nowhere), blast radius 10/20 (deployments sharing the network), 
reproducibility 18/20 (compose config output), maintenance value 4/20. 
**FIX_CONFIDENCE 75**.
   ### Tests
   Executed: `docker compose -f deploy/docker-compose.yml --env-file 
deploy/.env.example config` resolves `STUDIO_ROCKETMQ_NAMESRV_ADDR: 
rmq-nameserver:9876`; `docker compose -f deploy/rocketmq/docker-compose.yml 
config` still validates; `grep -rn "nameserver:9876" deploy/ | grep -v 
rmq-nameserver` now lists only the README's `docker compose exec nameserver ... 
-n nameserver:9876` diagnostics.
   ### Risk
   A deployment whose own NameServer container is named `nameserver` (rather 
than the demo stack's `rmq-nameserver`) must set 
`STUDIO_ROCKETMQ_NAMESRV_ADDR`, which the env template now documents.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to