The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/group-create-preserve-settings has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
039a030965dfb57a62f4fde778b5d233d5baa950 / unbridled-41 
<[email protected]>
fix(group): keep the import path's "register only, never overwrite" contract

The previous commit routed the import flag through the new per-master helper:

    admin.createAndUpdateSubscriptionGroupConfig(addr,
            importing ? config : createConfigForMaster(admin, addr, config, 
group));

which made an import write the *creation defaults* (consumeEnable=true,
consumeBroadcastEnable=true, retryQueueNums=1) to every master unconditionally,
killed the 409 for a config that differs (verifyGroupImport became unreachable) 
and
dropped the "existing config is only registered, never overwritten" contract the
topic import path still honours. The create-preservation change was only meant 
to
apply to a plain create.

Restore the import branch (register when every master matches, refuse with 409 
when
one differs, write only when no master has the group) and keep the per-master
preservation for a plain create. Two regression tests pin it: a matching group 
is not
rewritten, a differing config is refused and never written.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38007230218

With regards,
GitHub Actions via GitBox

Reply via email to