pilichoumao opened a new pull request, #6019:
URL: https://github.com/apache/rocketmq-dashboard/pull/6019

   ### Which Issue(s) This PR Fixes
   
   Fixes #6018
   
   ### Brief Description
   
   A failed Proxy stack query was reduced to null, and the subsequent Broker 
`CONSUMER_NOT_ONLINE` response incorrectly became 404. Preserve running-info 
query availability: a failed Proxy lookup plus an absent Broker result is 502; 
a successful direct-consumer Broker fallback still succeeds. Explicit offline 
replies remain distinguishable from failed/empty RPC responses, and interrupted 
running-info/Broker queries preserve interruption.
   
   The consumer modal now displays a localized capture-error notice for failed 
requests, and a separate no-stack notice for successful empty results. It no 
longer claims all Proxy clients lack capture support.
   
   The existing connection-list Resolver APIs stay intact. #5958 changes the 
connection aggregation path; #5255 changes client startup; #5529 touches nearby 
consumer-modal translations and may need a small rebase.
   
   ### How Did You Test This Change?
   
   Base: `rocketmq-studio@7e7aa344`; Java 21, Node 22.19.0. Frontend 
dependencies use the identical committed lockfile.
   
   - Fail-before probe on that base: Proxy query failure + Broker offline 
produced 404 instead of expected 502.
   - `cd server && mvn -o -B -ntp -Dmaven.repo.local=<local-cache> 
-Dspring.profiles.active=dev 
-Dtest=ProxyConsumerResolverTest,RocketMQConsumerDiagnosticsProviderTest,ConsumerGroupControllerTest
 test`: **51 tests, 0 failures/errors**, Checkstyle **0 violations**. Covers 
discovery/query failure, explicit offline, missing response/body, success after 
another Proxy fails, direct fallback, interruption and HTTP 502 mapping.
   - `cd web && npm test -- 
src/pages/instance/__tests__/ConsumerPage.test.tsx`: **49 passed**. The two new 
zh/en failure cases both fail against the old page implementation.
   - `cd web && npm test -- src/i18n`: **11 passed**; `npm run license:test`: 
**4 passed**.
   - `npm run lint`: **0 errors / 10 warnings in unchanged code**. Prettier and 
`git diff --check` pass.
   - `npm run build`: TypeScript and Vite succeed; the final license-manifest 
check fails on the generated main asset. An unmodified frontend at the same 
base fails at the same check.
   - `mvn -o -B -ntp -Dmaven.repo.local=<local-cache> -DskipTests package`: 
reaches the existing `binary-license-gate` and fails there; the same command on 
the base reproduces the same gate failure.
   
   No real Broker/Proxy outage, ACL/TLS, default MySQL integration suite or 
full frontend/backend test suite was run for this change. Network responses are 
simulated; this PR does not claim protocol-specific capture support.
   
   ### Checklist
   
   - [x] One coherent change; no unrelated refactor
   - [x] Conventional commit; new Java test methods end with `Test`
   - [x] Regression tests cover changed behavior
   - [x] New UI text has Chinese and English entries
   - [x] No new source files or dependencies
   - [x] Diagnostic behavior documented in `server/README.md`
   - [ ] Full CI green (license gates reproduce on the base)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to