Loyal-Young commented on PR #5384: URL: https://github.com/apache/rocketmq-dashboard/pull/5384#issuecomment-6094608234
Updated in d8ff6a619fc7b79e25a4979cf9962d1bcfe308b2. All five writers now acquire the same settingsInFlightRef; sendTest keeps it until testNotification settles. Appearance controls and both save forms share the busy state, and local theme/compact changes occur only after acquiring the lock. Added deferred tests for notification-test → appearance/security and preference-save → security/notification overlap, followed by successful saves after release. A separate validateFields rejection with errorFields verifies no API save/test or global error toast and then successfully saves security settings. Before: 2 new failures, 9 passes. After: 11 tests pass; changed-file ESLint, full app TypeScript (noEmit, composite/incremental false), and git diff --check pass. AI assistance was used for the revision and tests; I reviewed the diff and recorded results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
