zmuxuny commented on PR #5025: URL: https://github.com/apache/rocketmq-dashboard/pull/5025#issuecomment-6094758517
Updated in 86ec3e87f9c8ad0c5fcfd20250638cb9133ce5ae. It withdraws the message.tsx changes and keeps only MainLayout, its CSS/tests and the navigation-button translation. The separate page-controls follow-up https://github.com/apache/rocketmq-dashboard/issues/6063 covers all identified instance/cluster pages; 768px is explicitly scoped to MainLayout and is not proposed as a project convention. Current focused tests pass 56/56, tsc/format pass and lint has 0 errors. The final artifact-license gate fails on both this tree and clean current trunk. Fresh browser rendering is still blocked before browser startup by the cloud execution environment, so the old visual pass is not being represented as current validation. The 56 passing jsdom tests cover state transitions; they are not evidence that CSS media queries render correctly. Fresh visual verification remains outstanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
