pilichoumao opened a new pull request, #6323: URL: https://github.com/apache/rocketmq-dashboard/pull/6323
Fixes #6322. The L2/L3 interactive confirmation ignores failures writing its warning and destination prompt to stderr. With a pending `yes` answer, `group reset-offset` still sends preview and apply requests and exits 0 even though the prompt could not be delivered. Check both writes and return the wrapped error before reading the answer or starting its reader goroutine. Document this failure behavior; valid confirmation, cancellation, `--yes` and explicit dry-runs retain their existing paths. Validation against rocketmq-studio `5e4c39b053c35a5598cc79ff331b8a54e649d7b1`: - Both first-write and second-write regressions fail on baseline: exit 0, two HTTP requests, one answer read. After the fix: exit 1, zero requests and zero reads. - Direct tests preserve the original write error; actual App.Execute tests exercise the default confirmation and HTTP preview/apply path. Normal yes/no, --yes and dry-run controls pass; existing Ctrl-C tests remain passing. - `go test -race -count=1 -parallel 1 -timeout 60s ./...` passes. - `make fmt vet build-all` passes, including catalog consistency, six platform builds and license manifests. Checks ran sequentially with `GOMAXPROCS=1`, `GOMEMLIMIT=384MiB`, `GOFLAGS=-p=1`. Terminal mode is simulated using the existing character-device fixture; no live broker/database or mutation was used. AI-assisted implementation; final diff and raw regression evidence reviewed. These local Go results do not imply overall repository CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
