coder999o opened a new pull request, #7013: URL: https://github.com/apache/rocketmq-dashboard/pull/7013
## What is the purpose of the change Fixes #7012. Audit CSV rows contain unchanged server-local timestamps, but the header uses the server's offset at export time. In `America/New_York`, January and July records cannot both be described by that one offset. Name the server zone so historical daylight-saving rules remain available. ## Brief changelog - Use the JVM zone ID in the timestamp header and remove the current-offset helper. - Cover winter and summer audit records together; retain Shanghai and UTC coverage and verify local timestamp values remain unchanged. The first column name changes, for example, from `timestamp(UTC+08:00)` to `timestamp(Asia/Shanghai)`. `timestamp(UTC)` remains unchanged. External consumers matching the previous header literally must adapt. Column order and row values are unchanged. Zone-less storage still cannot distinguish the repeated hour during a DST overlap or recover a previous server zone. All-state duplicate review included #3995 (merged current-offset label), #6143 (same formula for other exports) and #6686 (JSON timestamp conversion, retaining local CSV values). This fix concerns historical DST metadata in the audit CSV only. ## Verifying this change Using JDK 22 with the project's Java 21 release target, from `server/`: - Before the production fix: `mvn -B -ntp -Dtest=AuditServiceTest#exportLogsNamesServerRegionForRecordsAcrossDaylightSavingSeasonsTest test` failed: the header was `timestamp(UTC-04:00)` for January and July local records. - After the fix: `mvn -B -ntp -Dtest=AuditServiceTest,AuditControllerTest,MybatisPlusAuditRepositoryTest,CsvUtilTest,OperationAuditServiceTest,AuditListToolHandlerTest test` passed all 50 tests with no failures, errors or skips; Maven validation reported zero Checkstyle violations. - `git diff --check` passed; the complete diff was reviewed for compatibility and scope. Evidence is from local unit/controller tests with mocked collaborators, not a deployed Studio/MySQL or RocketMQ run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
