RockteMQ-AI commented on issue #11466: URL: https://github.com/apache/rocketmq/issues/11466#issuecomment-6288433730
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** **Feasibility:** Feasible — bounded scope, configuration-driven change with clear defaults. **Scope:** Broker-side subscription group creation/validation paths. Likely affects `SubscriptionGroupManager` and related configuration classes. Does not require changes to client SDKs or gRPC protocol validation. **Compatibility:** No breaking changes. Default remains 120 characters; only operators who explicitly raise the limit are affected. The 255-character cap preserves the existing retry-topic length invariant. **Assessment:** This is a well-scoped enhancement that addresses a real operational need. The proposed design — broker-side configurable limit with a hard cap at 255, default unchanged at 120 — is sound. Key considerations for implementation: 1. The configuration should be dynamically reloadable (consistent with other broker configs) to avoid restart requirements. 2. Validation at the broker-side creation path must enforce `min(default_max, configured_max)` to prevent operators from accidentally exceeding the retry-topic length constraint. 3. The DLQ topic length constraint (127 bytes for `%DLQ%<group>`) mentioned in the issue should remain unaffected — this is a separate storage-layer limit. 4. Documentation update should accompany the change to clarify the relationship between subscription group length, retry topic length, and DLQ topic length. This enhancement is a good candidate for community contribution. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
