RockteMQ-AI commented on issue #11474: URL: https://github.com/apache/rocketmq/issues/11474#issuecomment-6306997460
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** `proxy` module — `ProxyMetricsManager`, `ProxyAdminAuthInterceptor`, admin gRPC server initialization **Compatibility:** No breaking changes — additive instrumentation only The proposal is well-scoped and addresses a real observability gap. The admin gRPC interface currently has no metrics beyond `rocketmq_proxy_up`, making it impossible to monitor admin API usage, latency, or failures. **Assessment:** - Adding per-RPC counters and latency histograms via an interceptor is a standard OpenTelemetry pattern - Auth interceptor instrumentation (counting rejections) is a good addition for security monitoring - No proto changes required — metrics can be added at the interceptor layer - Graceful degradation when metrics are disabled aligns with existing broker patterns This enhancement would significantly improve operational visibility for the proxy control plane. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
