PawasChhokra commented on a change in pull request #1008: SAMZA-2174: Throw a
record too large exception for oversized records in changelog
URL: https://github.com/apache/samza/pull/1008#discussion_r287028529
##########
File path:
samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala
##########
@@ -35,15 +35,22 @@ import org.apache.samza.util.ScalaJavaUtil.JavaOptionals
import org.apache.samza.util.{HighResolutionClock, ScalaJavaUtil}
/**
- * A key value storage engine factory implementation
- *
- * This trait encapsulates all the steps needed to create a key value storage
engine. It is meant to be extended
- * by the specific key value store factory implementations which will in turn
override the getKVStore method.
- */
+ * A key value storage engine factory implementation
+ *
+ * This trait encapsulates all the steps needed to create a key value storage
engine. It is meant to be extended
+ * by the specific key value store factory implementations which will in turn
override the getKVStore method.
+ */
trait BaseKeyValueStorageEngineFactory[K, V] extends StorageEngineFactory[K,
V] {
private val INMEMORY_KV_STORAGE_ENGINE_FACTORY =
"org.apache.samza.storage.kv.inmemory.InMemoryKeyValueStorageEngineFactory"
+ private val CHANGELOG_MAX_MSG_SIZE_BYTES = "changelog.max.message.size.bytes"
+ private val DEFAULT_CHANGELOG_MAX_MSG_SIZE_BYTES = 1000000 // slightly less
than 1 MB
+ private val EXPECT_LARGE_MESSAGES = "expect.large.message"
Review comment:
Sorry I missed this earlier. Added to the docs now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
