PawasChhokra commented on a change in pull request #1008: SAMZA-2174: Throw a record too large exception for oversized records in changelog URL: https://github.com/apache/samza/pull/1008#discussion_r287537434
########## File path: samza-kv/src/main/scala/org/apache/samza/storage/kv/LargeMessageSafeStore.scala ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.storage.kv +import java.util + +import org.apache.samza.SamzaException + +import scala.collection.JavaConverters.iterableAsScalaIterableConverter + +/** + * A wrapper over KeyValueStore that checks to see if any large messages have been passed to the store. + * + * @param store the store to persist to if messages are not large + * @param storeName store name + * @param dropLargeMessage a flag that determines if we want to ignore and drop large messages + * @param maxMessageSize maximum allowed size of a message, after which every message will be considered large + */ +class LargeMessageSafeStore( Review comment: Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
