rmatharu commented on a change in pull request #1137: SAMZA-2301: Improve 
zookeeper metadata-store implementation
URL: https://github.com/apache/samza/pull/1137#discussion_r313983464
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/zk/ZkJobCoordinator.java
 ##########
 @@ -356,10 +356,12 @@ JobModel generateNewJobModel(List<ProcessorNode> 
processorNodes) {
     // If JobModel exists in zookeeper && cached JobModel version is unequal 
to JobModel version stored in zookeeper.
     if (zkJobModelVersion != null && !Objects.equals(cachedJobModelVersion, 
zkJobModelVersion)) {
 
 Review comment:
   Looks like TestZkLocalApplicationRunner.java needs to also be updated, there 
are some failed tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to