rmatharu commented on a change in pull request #1137: SAMZA-2301: Improve
zookeeper metadata-store implementation
URL: https://github.com/apache/samza/pull/1137#discussion_r313987126
##########
File path: samza-core/src/main/java/org/apache/samza/zk/ZkMetadataStore.java
##########
@@ -103,6 +104,25 @@ public void init() {
return null;
}
+ private byte[] readFromZk(String zkPath) {
+ long retryTimeOutMs = zkConfig.getZkSessionTimeoutMs();
+ long startTimeMs = System.currentTimeMillis();
+ while (true) {
+ try {
+ byte[] value = zkClient.readData(zkPath);
+ LOG.info("Read for zkPath: {} returned: {}.", zkPath, value);
Review comment:
printing value will just print the reference right?
if this is encoded, could you print it as a string instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
