prateekm commented on a change in pull request #1187: Notifying BEM about
kafkaConsumerProxy failure to prevent BEM poll-blockin in case of proxy failures
URL: https://github.com/apache/samza/pull/1187#discussion_r334662064
##########
File path:
samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java
##########
@@ -141,7 +143,7 @@ private void
initializeInternalStateForSSP(SystemStreamPartition systemStreamPar
if (timeout == SystemConsumer.BLOCK_ON_OUTSTANDING_MESSAGES) {
// Block until we get at least one message, or until we catch up to
// the head of the stream.
- while (envelope == null && !isAtHead(systemStreamPartition)) {
+ while (envelope == null && !isAtHead(systemStreamPartition) &&
!isConsumerFailed()) {
Review comment:
Nitpick: Reverse order of isConsumerFailed and isAtHead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
