prateekm commented on a change in pull request #1187: Notifying BEM about
kafkaConsumerProxy failure to prevent BEM poll-blockin in case of proxy failures
URL: https://github.com/apache/samza/pull/1187#discussion_r334663219
##########
File path:
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaConsumerProxy.java
##########
@@ -204,6 +204,7 @@ private Runnable createProxyThreadRunnable() {
// KafkaSystemConsumer uses the failureCause to propagate the
throwable to the container
failureCause = throwable;
isRunning = false;
+ ((KafkaSystemConsumer)
this.kafkaConsumer).setProxyFailureCause(this.failureCause);
Review comment:
Does this work? Isn't kafkaConsumer the actual Kafka Consumer, not the
SystemConsumer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
