prateekm commented on a change in pull request #1173: SAMZA-2333: [AM isolation] Use cytodynamics classloader to launch job coordinator URL: https://github.com/apache/samza/pull/1173#discussion_r350433481
########## File path: samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java ########## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.classloader; + +import com.linkedin.cytodynamics.matcher.BootstrapClassPredicate; +import com.linkedin.cytodynamics.matcher.GlobMatcher; +import com.linkedin.cytodynamics.nucleus.DelegateRelationship; +import com.linkedin.cytodynamics.nucleus.DelegateRelationshipBuilder; +import com.linkedin.cytodynamics.nucleus.IsolationLevel; +import com.linkedin.cytodynamics.nucleus.LoaderBuilder; +import com.linkedin.cytodynamics.nucleus.OriginRestriction; +import java.io.File; +import java.io.IOException; +import java.net.MalformedURLException; +import java.net.URI; +import java.net.URISyntaxException; +import java.net.URL; +import java.net.URLClassLoader; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.util.List; +import java.util.stream.Collectors; +import java.util.stream.Stream; +import com.google.common.annotations.VisibleForTesting; +import org.apache.samza.SamzaException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Use this to build a classloader for running Samza which isolates the Samza framework code/dependencies from the + * application code/dependencies. + */ +public class IsolatingClassLoaderFactory { + private static final Logger LOG = LoggerFactory.getLogger(IsolatingClassLoaderFactory.class); + + private static final String LIB_DIRECTORY = "lib"; + + /** + * Build a classloader which will isolate Samza framework code from application code. Samza framework classes and Review comment: Nice, thanks for the thorough documentation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
