prateekm commented on a change in pull request #1173: SAMZA-2333: [AM
isolation] Use cytodynamics classloader to launch job coordinator
URL: https://github.com/apache/samza/pull/1173#discussion_r350432555
##########
File path:
samza-core/src/main/java/org/apache/samza/classloader/DependencyIsolationUtils.java
##########
@@ -25,16 +25,24 @@
* TODO make this configurable or taken from an environment variable
*/
public static final String FRAMEWORK_API_DIRECTORY = "__samzaFrameworkApi";
+
/**
* Directory inside the home directory of the cluster-based job coordinator
in which the framework infrastructure
* artifacts are placed, for usage in dependency isolation for the
cluster-based job coordinator.
* TODO make this configurable or taken from an environment variable
*/
public static final String FRAMEWORK_INFRASTRUCTURE_DIRECTORY =
"__samzaFrameworkInfrastructure";
+
/**
* Directory inside the home directory of the cluster-based job coordinator
in which the application artifacts are
* placed, for usage in dependency isolation for the cluster-based job
coordinator.
* TODO make this configurable or taken from an environment variable
*/
public static final String APPLICATION_DIRECTORY = "__package";
+
+ /**
+ * Name of the file which contains the class names (or globs) which should
be loaded from the framework API
+ * classloader.
+ */
+ public static final String FRAMEWORK_API_CLASS_LIST_FILE_NAME =
"samza-framework-api-class-list.txt";
Review comment:
Nitpick: maybe samza-framework-api-classes.txt and same for the variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
