kw2542 commented on a change in pull request #1238: SAMZA-2407: Add job.config.loader.* configs in JobConfig & corresponding env variables in ShellCommandConfig URL: https://github.com/apache/samza/pull/1238#discussion_r363415651
########## File path: samza-core/src/main/java/org/apache/samza/config/JobConfig.java ########## @@ -47,6 +47,15 @@ public static final String CONFIG_REWRITERS = "job.config.rewriters"; public static final String CONFIG_REWRITER_CLASS = "job.config.rewriter.%s.class"; + /** + * job.config.loader.factory specifies {@link ConfigLoaderFactory} to get {@link ConfigLoader} + */ + public static final String CONFIG_LOADER_FACTORY = "job.config.loader.factory"; + /** + * job.config.loader.properties prefix wraps properties needed for {@link ConfigLoader} to loader config. Review comment: Added ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services