kw2542 commented on a change in pull request #1238: SAMZA-2407: Add
job.config.loader.* configs in JobConfig & corresponding env variables in
ShellCommandConfig
URL: https://github.com/apache/samza/pull/1238#discussion_r364971144
##########
File path: samza-core/src/main/java/org/apache/samza/config/JobConfig.java
##########
@@ -47,6 +47,17 @@
public static final String CONFIG_REWRITERS = "job.config.rewriters";
public static final String CONFIG_REWRITER_CLASS =
"job.config.rewriter.%s.class";
+ /**
+ * job.config.loader.factory specifies {@link ConfigLoaderFactory} to get
{@link ConfigLoader}
+ */
+ public static final String CONFIG_LOADER_FACTORY =
"job.config.loader.factory";
+ /**
+ * job.config.loader.properties prefix wraps properties needed for {@link
ConfigLoader} to loader config.
+ * e.g. {@link org.apache.samza.config.loaders.PropertiesConfigLoaderFactory}
+ * will read job.config.loader.properties.path to locate the config file
location
+ */
+ public static final String CONFIG_LOADER_PROPERTIES_PREFIX =
"job.config.loader.properties.";
Review comment:
Yes, it is supposed to be only used by config loader, which specifies
properties it needed to retrieve full job config.
Are you suggesting we move this to ConfigLoader instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
