bkonold commented on a change in pull request #1247: SAMZA-2408: Update
RemoteApplicationRunner to submit job only
URL: https://github.com/apache/samza/pull/1247#discussion_r366101726
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/RemoteApplicationRunner.java
##########
@@ -57,13 +55,21 @@
* @param config configuration for the application
*/
public RemoteApplicationRunner(SamzaApplication app, Config config) {
- this.appDesc = ApplicationDescriptorUtil.getAppDescriptor(app, config);
- this.planner = new RemoteJobPlanner(appDesc);
+ this.app = app;
+ this.config = config;
}
@Override
public void run(ExternalContext externalContext) {
+ if (new JobConfig(config).getConfigLoaderFactory().isPresent()) {
+ JobRunner runner = new JobRunner(config);
+ runner.submit();
+ return;
+ }
+
+ // TODO: Clean this up once SAMZA-2405 is completed when legacy flow is
removed.
Review comment:
Would it be helpful to create a ticket for this cleanup work (for all
changes related to the SEP) so we don't lose track of it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
