cameronlee314 commented on a change in pull request #1247: SAMZA-2408: Update
RemoteApplicationRunner to submit job only
URL: https://github.com/apache/samza/pull/1247#discussion_r367032749
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/RemoteApplicationRunner.java
##########
@@ -85,7 +91,7 @@ public void kill() {
// since currently we only support single actual remote job, we can get
its status without
// building the execution plan.
try {
- JobConfig jc = new
JobConfig(JobPlanner.generateSingleJobConfig(appDesc.getConfig()));
+ JobConfig jc = new JobConfig(JobPlanner.generateSingleJobConfig(config));
Review comment:
This is a question for `kill`, `status`, and `waitForFinish`:
Should you be calling `JobPlanner.generateSingleJobConfig` even when config
loader factory is specified? It seems like you would want to call `JobRunner`,
similar to how you changed it for `run`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
