cameronlee314 commented on a change in pull request #1247: SAMZA-2408: Update
RemoteApplicationRunner to submit job only
URL: https://github.com/apache/samza/pull/1247#discussion_r367135023
##########
File path:
samza-core/src/test/java/org/apache/samza/runtime/TestRemoteApplicationRunner.java
##########
@@ -75,9 +75,20 @@ public void testWaitForFinishTimesout() {
assertFalse("Application finished before the timeout.", finished);
}
+ @Test
+ public void testRunWithConfigLoaderFactoryPresent() {
Review comment:
+1 that there is a bit of missing test coverage here. It would be nice if
this class was set up better for improved testing, but I also won't block the
PR on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
