cameronlee314 commented on a change in pull request #1266: Adding internal
autosizing related configs
URL: https://github.com/apache/samza/pull/1266#discussion_r374854689
##########
File path: samza-core/src/main/java/org/apache/samza/config/JobConfig.java
##########
@@ -286,8 +304,19 @@ public String getSSPMatcherConfigJobFactoryRegex() {
return get(SSP_MATCHER_CONFIG_JOB_FACTORY_REGEX,
DEFAULT_SSP_MATCHER_CONFIG_JOB_FACTORY_REGEX);
}
+ /**
+ * Return the value of JOB_CONTAINER_THREAD_POOL_SIZE if autosizing is not
enabled,
+ * otherwise returns the value of JOB_AUTOSIZING_CONTAINER_THREAD_POOL_SIZE.
+ * @return
+ */
public int getThreadPoolSize() {
- return getInt(JOB_CONTAINER_THREAD_POOL_SIZE, 0);
+ Optional<String> autoscalingContainerThreadPoolSize =
Optional.ofNullable(get(
Review comment:
Same about `autosizing` instead of `autoscaling`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
