cameronlee314 commented on a change in pull request #1266: Adding internal
autosizing related configs
URL: https://github.com/apache/samza/pull/1266#discussion_r374872256
##########
File path:
samza-core/src/main/scala/org/apache/samza/util/CoordinatorStreamUtil.scala
##########
@@ -163,7 +163,14 @@ object CoordinatorStreamUtil extends Logging {
val oldConfig = coordinatorSystemConsumer.getConfig
if (resetJobConfig) {
- val keysToRemove =
oldConfig.keySet.asScala.toSet.diff(config.keySet.asScala)
+ var keysToRemove =
oldConfig.keySet.asScala.toSet.diff(config.keySet.asScala)
+
+ val jobConfig = new JobConfig(config)
+ if (jobConfig.getAutosizingEnabled) {
+ // If autosizing is enabled, we retain auto-sizing related configs
+ keysToRemove = keysToRemove.filter(configKey =>
!jobConfig.isAutosizingConfig(configKey))
Review comment:
Is there a case where you want to intentionally delete an autosizing config?
For example, for cleaning up after getting a stable set of parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
