mynameborat commented on a change in pull request #1327: SAMZA-2493: Keep checkpoint manager consumer open for repeated polling URL: https://github.com/apache/samza/pull/1327#discussion_r401217615
########## File path: samza-core/src/main/java/org/apache/samza/config/TaskConfig.java ########## @@ -105,6 +105,7 @@ private static final String BROADCAST_STREAM_PATTERN = "^[\\d]+$"; private static final String BROADCAST_STREAM_RANGE_PATTERN = "^\\[[\\d]+\\-[\\d]+\\]$"; public static final String CHECKPOINT_MANAGER_FACTORY = "task.checkpoint.factory"; + public static final String CHECKPOINT_MANAGER_CONSUMER_STOP_AFTER_FIRST_READ = "task.checkpoint.consumer.stop.after.first.read"; Review comment: +1 to internal prefix. We were debating between passing the exposing task mode through parameter vs config. The config route seemed less invasive and also doesn't introduce breaking API changes. IIRC, we want to know if the container is standby or not. Given KafkaCheckpointManager is a singleton for the container, is there a way to infer on the fly from the existing configurations if it is standby or active? for e.g. task.inputs is empty? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
