bkonold commented on a change in pull request #1327: SAMZA-2493: Keep checkpoint manager consumer open for repeated polling URL: https://github.com/apache/samza/pull/1327#discussion_r401947082
########## File path: samza-core/src/main/java/org/apache/samza/config/TaskConfig.java ########## @@ -105,6 +105,7 @@ private static final String BROADCAST_STREAM_PATTERN = "^[\\d]+$"; private static final String BROADCAST_STREAM_RANGE_PATTERN = "^\\[[\\d]+\\-[\\d]+\\]$"; public static final String CHECKPOINT_MANAGER_FACTORY = "task.checkpoint.factory"; + public static final String CHECKPOINT_MANAGER_CONSUMER_STOP_AFTER_FIRST_READ = "task.checkpoint.consumer.stop.after.first.read"; Review comment: I spoke with @rmatharu and there is nothing in config we can use to infer standby vs not. If we're all ok with the internal config, I will change the prefix and we can go with that. May also be worth pointing out that this PR doesn't do much to lock us into anything - if we later want to treat this information as more a first class citizen we can go ahead and change the factory API. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
