kw2542 commented on a change in pull request #1437:
URL: https://github.com/apache/samza/pull/1437#discussion_r525832466
##########
File path:
samza-core/src/main/java/org/apache/samza/coordinator/metadatastore/CoordinatorStreamStore.java
##########
@@ -111,6 +111,12 @@ public void init() {
systemConsumer.start();
systemProducer.register(SOURCE);
systemProducer.start();
+ Runtime.getRuntime().addShutdownHook(new Thread(() -> {
+ LOG.info("CoordinatorStreamStore Shut Down Hook thread is closing
kafka clients");
+ this.systemProducer.stop();
Review comment:
can we do this.close() ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
