kw2542 commented on a change in pull request #1437: URL: https://github.com/apache/samza/pull/1437#discussion_r525832870
########## File path: samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala ########## @@ -112,6 +115,12 @@ class KafkaCheckpointManager(checkpointSpec: KafkaStreamSpec, info(s"Starting the checkpoint SystemConsumer from oldest offset $oldestOffset") systemConsumer.register(checkpointSsp, oldestOffset) systemConsumer.start() + Runtime.getRuntime.addShutdownHook(new Thread("KafkaCheckPointManagerShutdownHook") { + override def run(): Unit = { + producerRef.get().stop() Review comment: this.stop()? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org