prateekm commented on a change in pull request #1429:
URL: https://github.com/apache/samza/pull/1429#discussion_r594679611



##########
File path: 
samza-api/src/main/java/org/apache/samza/storage/TaskBackupManager.java
##########
@@ -43,32 +45,40 @@
 public interface TaskBackupManager {
 
   /**
-   * Initializes the TaskBackupManager instance
-   * @param checkpoint Last recorded checkpoint from the CheckpointManager or 
null if no last checkpoint was found
+   * Initializes the TaskBackupManager instance.
+   *
+   * @param checkpoint last recorded checkpoint from the CheckpointManager or 
null if no last checkpoint was found
    */
   void init(@Nullable Checkpoint checkpoint);
 
   /**
-   * Commit operation that is synchronous to processing
+   *  Snapshot is used to capture the current state of the stores in order to 
persist it to the backup manager in the
+   *  {@link #upload(CheckpointId, Map)} phase. Performs the commit operation 
that is synchronous
+   *  to processing. Returns the per store name state snapshotted checkpoints 
to be used in upload.

Review comment:
       "per store state checkpoint markers"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to