prateekm commented on a change in pull request #1429:
URL: https://github.com/apache/samza/pull/1429#discussion_r594675667
##########
File path:
samza-core/src/main/java/org/apache/samza/storage/TaskSideInputStorageManager.java
##########
@@ -211,7 +211,7 @@ private boolean isPersistedStore(String storeName) {
private void validateStoreConfiguration(Map<String, StorageEngine> stores) {
stores.forEach((storeName, storageEngine) -> {
- if (storageEngine.getStoreProperties().isLoggedStore()) {
+ if (storageEngine.getStoreProperties().isDurableStore()) {
Review comment:
This should still be isLoggedStore. Side input stores are durable, this
is just checking that they don't have a changelog too (since side input ==
changelog)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
