ajothomas commented on code in PR #1616: URL: https://github.com/apache/samza/pull/1616#discussion_r930409996
########## samza-core/src/main/java/org/apache/samza/coordinator/metadatastore/NamespaceAwareCoordinatorStreamStore.java: ########## @@ -35,6 +35,10 @@ public class NamespaceAwareCoordinatorStreamStore implements MetadataStore { private final MetadataStore metadataStore; private final String namespace; + public MetadataStore getMetadataStore() { + return metadataStore; + } + Review Comment: I think i added it for some test but not necessary anymore. Removed it. ########## samza-core/src/main/java/org/apache/samza/config/JobConfig.java: ########## @@ -169,6 +169,9 @@ public class JobConfig extends MapConfig { public static final String DRAIN_MONITOR_ENABLED = "samza.drain-monitor.enabled"; public static final boolean DRAIN_MONITOR_ENABLED_DEFAULT = false; + public static final String DRAIN_MONITOR_POLL_INTERVAL_MILLIS = "samza.drain-monitor.poll.interval.ms"; + public static final long DRAIN_MONITOR_POLL_INTERVAL_MILLIS_DEFAULT = 60_000; Review Comment: Did not notice that this wasn't consistent. Changed this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org