ajothomas commented on code in PR #1616: URL: https://github.com/apache/samza/pull/1616#discussion_r930412218
########## samza-api/src/main/java/org/apache/samza/system/DrainMessage.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.system; + +import com.fasterxml.jackson.annotation.JsonProperty; + +/** + * The DrainMessage is a control message that is sent out to next stage + * once the task has consumed to the end of a bounded stream. + */ +public class DrainMessage extends ControlMessage { + /** + * Id used to invalidate DrainMessages between runs. Ties to app.run.id from config. + */ + private final String runId; + + public DrainMessage(String runId) { + this(null, runId); + } + + public DrainMessage(@JsonProperty("task-name") String taskName, @JsonProperty("run-id") String runId) { Review Comment: I wasn't aware that we were using jackson mixin to model classes. Thanks. DrainMessage, however, extends a ControlMessage base class which in turn is used by a couple of other classes. Should we still be using mixin for cases like these? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
