mynameborat commented on code in PR #1647:
URL: https://github.com/apache/samza/pull/1647#discussion_r1068483167
##########
docs/meetups/index.html:
##########
@@ -21,7 +21,7 @@
-->
<div class="meetups" data-plugin="paginate" data-max-posts="2"
data-previous=".paginate-previous--meetup" data-next=".paginate-next--meetup"
data-pagination=".pagination--meetup">
- {% assign sorted = (site.meetups | sort: 'date') | reverse %}
+ {% assign sorted = site.meetups | sort: 'date' | reverse %}
Review Comment:
why do we need these changes?
##########
docs/talks/index.html:
##########
@@ -21,7 +21,7 @@
-->
<div class="talks" data-plugin="paginate" data-max-posts="2"
data-previous=".paginate-previous--talk" data-next=".paginate-next--talk"
data-pagination=".pagination--talk">
- {% assign sorted = (site.talks | sort: 'date') | reverse %}
+ {% assign sorted = site.talks | sort: 'date' | reverse %}
Review Comment:
same as above. can we exclude these changes if they are not part of the
original issue this RB is solving?
##########
docs/_blog/index.md:
##########
@@ -22,7 +22,7 @@ exclude_from_loop: true
<div class="news_cards">
- {% assign sorted = (site.blog | sort: 'date') | reverse %}
+ {% assign sorted = site.blog | sort: 'date' | reverse %}
Review Comment:
revert unless its related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
