li-afaris opened a new pull request, #1647:
URL: https://github.com/apache/samza/pull/1647
# Summary
This change moves Jekyll dependency management into Gradle. Contributors
will no longer be required to install ruby & Jekyll by hand.
# Changes
* Gemfiles no longer manage dependencies. This is done with the
jruby-gradle-plugin Gradle plugin.
* rubygems.org is still the source of Ruby libraries
* The locally install MRI Ruby interpreter is replaced with JRuby.
* This allows the Ruby interpreter to be a part of the Samza project.
* Jekyll plugin changes
* Rouge replaces pygments.rb. Rouge is native Ruby and does not have a
python requirement.
* Kramdown replaces Redcarpet because Redcarpet does not work with
JRuby.
* Both Kramdown & Rouge can run inside the JRuby JVM.
* buildscript.gradle
* jcenter.bintray.com is no longer active.
* plugins.gradle.org has the required plugins
# Testing
Testing was done with JDK 1.8 and on Linux. I visually confirmed that
content generated with JRuby looks like content generated by MRI Ruby by
running two Jekyll instances at the same time. Both Jekyll instances threw the
same errors for missing content at `/learn/documentation/latest`. I'm open to
suggestions for improving confidence relating to the Jekyll plugin changes.
I also ran `./gradlew test` which built successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
