[ 
https://issues.apache.org/jira/browse/SAMZA-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740630#comment-13740630
 ] 

Jay Kreps commented on SAMZA-14:
--------------------------------

For JIRA reviews its good to number the items to make discussion easier.

logging stacktrace: I agree in theory. The reality is I was getting insane 
messages and had to add that to debug what they even meant:
  Triggering a reconnect for %s because connection failed: 
java.lang.ClassCastException: java.lang.String cannot be cast to [B
I figured out this had to do with a typo in the serde only due to stepping 
through it in a debugger. If you think this is the only case like that I think 
that can be fixed by just improving the handling of no serialization.

Logging: it can. Doesn't yarn handle this for us? It must, right? They execute 
the process so they should have ahold of our output stream. Otherwise isn't 
that a more general problem...

Configs: very likely. They were originally needed but didn't get removed during 
the task runner refactor.

Name extension: This was already there. Now that we have non-job properties it 
is important to be able to figure out what is a job and what isn't. Not wedded 
to that extension. Let's figure out the extension and I can include any other 
jobs.

Config: In general I am not smart enough to figure out how to configure things.


                
> Fix misc bugs in QA jobs
> ------------------------
>
>                 Key: SAMZA-14
>                 URL: https://issues.apache.org/jira/browse/SAMZA-14
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Jay Kreps
>            Assignee: Jay Kreps
>         Attachments: SAMZA-14-v1.patch
>
>
> Some bugs that have already been there and some that came with the various 
> package refactorings.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to