[
https://issues.apache.org/jira/browse/SAMZA-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065679#comment-14065679
]
Chris Riccomini commented on SAMZA-345:
---------------------------------------
As stated in SAMZA-109, I've grown to think that this is not a really great
idea. My fear is just that it's a bit clunky, and could be confusing to users
as to why some environment variables are available via task.opts, and others
are not.
> String replacement in environment variables
> -------------------------------------------
>
> Key: SAMZA-345
> URL: https://issues.apache.org/jira/browse/SAMZA-345
> Project: Samza
> Issue Type: Bug
> Components: container
> Affects Versions: 0.8.0
> Reporter: Chinmay Soman
>
> Following up from SAMZA-109
> We need to do the following things:
> 1. Add CommandBuilder.setLogDir.
> 2. Make ShellCommandBuilder.buildEnvironment do a string replace for
> task.opts (ENV_JAVA_OPTS) to replace $SAMZA_LOG_DIR with log dir, and
> $SAMZA_CONTAINER_NAME with container name.
> 3. Update SamzaAppMasterTaskManager, and ProcessJobFactory to use the new
> CommandBuilder.setLogDir method.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
