[
https://issues.apache.org/jira/browse/SAMZA-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065683#comment-14065683
]
Chris Riccomini commented on SAMZA-343:
---------------------------------------
The things that I think should persist when task.opts is supplied are:
{noformat}
-server -Dsamza.log.dir=$SAMZA_LOG_DIR
-Dsamza.container.name=$SAMZA_CONTAINER_NAME -Djava.io.tmpdir=$JAVA_TEMP_DIR
{noformat}
I also was thinking it'd be cool to auto-enable -d64 if it's available. This
seems to require a manual test before setting it since my 32 bit JVM was
complaining when -d64 was set.
{code}
# try and use 64-bit mode if available
`java -d64 -version`
if [ $? -eq 0 ] ; then
JAVA_OPTS="$JAVA_OPTS -d64"
fi
{code}
Another thought as part of this ticket would be to eliminate the:
{code}
if [ -z "$SAMZA_LOG4J_CONFIG" ]; then
export SAMZA_LOG4J_CONFIG=file:$(dirname $0)/../lib/log4j.xml
fi
{code}
In run-container.sh and run-am.sh, and having run-class.sh default
SAMZA_LOG4J_CONFIG to the log4j.xml file instead. We can leave the
log4j-console.xml overrides for things like checkpoint-tool.sh, though.
As [~martinkl] said in SAMZA-109, it'd be nice if we could retain GC log
settings as well, but I think we then would need to figure out a way to handle
GC log setting overrides. Maybe we just need some "disable default CLI
settings" switch to disable everything in cases where people want to set their
own GC logs, or disable -server, or something.
> Make task.opts easier to user (part 1)
> --------------------------------------
>
> Key: SAMZA-343
> URL: https://issues.apache.org/jira/browse/SAMZA-343
> Project: Samza
> Issue Type: Sub-task
> Components: container
> Affects Versions: 0.8.0
> Reporter: Chinmay Soman
> Assignee: Chinmay Soman
> Fix For: 0.8.0
>
>
> Address following things in this sub-task:
> 1. Eliminate LocalJobFactory.
> 2. Create ProcessJobFactory.
> 3. Create ThreadJobFactory.
> 5. Forcibly assign the log4j.xml file (if it exists), and the
> samza.log.dir/samza.container.name Java system properties.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
