[
https://issues.apache.org/jira/browse/SAMZA-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096075#comment-14096075
]
Chris Riccomini commented on SAMZA-361:
---------------------------------------
bq. Looks like having MDC put/clear methods in the logging class is sufficient.
Not quite sure what you mean here. In my little proposal above, I don't think
it's sufficient because we unset the MDC's task name at the end of the log
method. This means that the logging done inside of the StreamTask will *not*
have the task name set (I think). I think it'd be preferable to have the task
name set in log messages from the StreamTask, if we can do so in a relatively
clean way. Maybe I'm misunderstanding what you're saying, though.
bq. From https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/MDC.html
, "The MDC is managed on a per thread basis". So seems that we can think MDC is
threadsafe.
Awesome. Was hoping they'd be using thread local.
> Remove Grizzled SLF4J
> ---------------------
>
> Key: SAMZA-361
> URL: https://issues.apache.org/jira/browse/SAMZA-361
> Project: Samza
> Issue Type: Bug
> Components: container
> Affects Versions: 0.8.0
> Reporter: Chris Riccomini
> Fix For: 0.8.0
>
>
> The cons of Grizzled SLF4J outweigh the pros. We can [create a single
> class|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/utils/Logging.scala]
> that does what we need for logging. Eliminating the Grizzled dependency
> means that we'll have one less Scala binary to depend on. It will also give
> us more control over SLF4J APis that we might want to use (e.g. the
> [MDC|http://www.slf4j.org/api/org/slf4j/MDC.html], see SAMZA-310).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
