[ 
https://issues.apache.org/jira/browse/SAMZA-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097495#comment-14097495
 ] 

Chris Riccomini commented on SAMZA-361:
---------------------------------------

bq. lWhen we have the use case that needs taskName attached with the log, then 
we look further into the toggling MDC from logging class?

Yea, I think I agree.

bq. So my gut feeling is that, let's leave the toggling MDC logic out of the 
logging class so far and only provide the MDC API from our logging class.

Sounds good!

> Remove Grizzled SLF4J
> ---------------------
>
>                 Key: SAMZA-361
>                 URL: https://issues.apache.org/jira/browse/SAMZA-361
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.8.0
>            Reporter: Chris Riccomini
>             Fix For: 0.8.0
>
>
> The cons of Grizzled SLF4J outweigh the pros. We can [create a single 
> class|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/utils/Logging.scala]
>  that does what we need for logging. Eliminating the Grizzled dependency 
> means that we'll have one less Scala binary to depend on. It will also give 
> us more control over SLF4J APis that we might want to use (e.g. the 
> [MDC|http://www.slf4j.org/api/org/slf4j/MDC.html], see SAMZA-310).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to