[ 
https://issues.apache.org/jira/browse/SAMZA-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215151#comment-14215151
 ] 

Chris Riccomini commented on SAMZA-430:
---------------------------------------

[~nickpan47], looks good. Few notes:

# Please post patch on JIRA with link to RB. This is what grants rights to 
Apache.
# We'll need to remove Scala 2.9.2 support. `./gradlew clean build -x test 
-PscalaVersion=2.9.2` fails, since Scala made a backwards incompatible API 
change with their BeanProperty package space.
# We should try and add Scala 2.110 support as part of this ticket (and make it 
the default).
# Somehow a scala.collection.concurrent line got added to BrokerProxy.scala. 
Was this intentional?

Regarding (3), if we meet too much resistance, we can open up a separate ticket 
for 2.11 support. There might be issues with  [Scalatra|http://scalatra.org/], 
which will need to be upgraded to 2.3.0 to support 2.11, so if it starts taking 
too long, we'll just open up a separate ticket to investigate.

> scala.reflect.BeanProperty deprecated
> -------------------------------------
>
>                 Key: SAMZA-430
>                 URL: https://issues.apache.org/jira/browse/SAMZA-430
>             Project: Samza
>          Issue Type: Improvement
>          Components: build, container
>            Reporter: bennett andrews
>            Assignee: Yi Pan (Data Infrastructure)
>             Fix For: 0.9.0
>
>
> BeanProperty moved from scala.reflect to scala.beans in 2.10 and has been 
> removed from 2.11 so needs to be changed in order to compile on 2.11.
> incubator-samza/samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsHeader.scala:48:
>  error: not found: type BeanProperty
> [ant:scalac]   @BeanProperty val source: String,
> [ant:scalac]    ^



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to