[
https://issues.apache.org/jira/browse/SAMZA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221240#comment-14221240
]
Chris Riccomini commented on SAMZA-473:
---------------------------------------
bq. Is it worth having the different serializers in their own projects
(samza-serializer-avro, samza-serializer-protobufs, samza-serializer-capnproto,
etc) to avoid this type of dependency mingling in core?
Yes, totally. Sorry if that wasn't clear. I think what we need is:
# Serdes that bring in NO new dependencies can reside in core.
# Serdes that have ANY dependencies reside in their OWN modules
(samza-serializers-avro, etc).
What we have now is a bunch of serializers that can go in core (because they
have no new dependencies that aren't already in core). This patch moves those
serdes into core, and eliminates the potential cess-pool that would result from
a single samza-serializers package. As new serdes are added, we can follow the
decision flow listed above to add them into the code base.
I think we agree. :)
> Remove samza-serializers package
> --------------------------------
>
> Key: SAMZA-473
> URL: https://issues.apache.org/jira/browse/SAMZA-473
> Project: Samza
> Issue Type: Bug
> Components: container
> Affects Versions: 0.9.0
> Reporter: Chris Riccomini
> Assignee: Chris Riccomini
> Labels: newbie
> Fix For: 0.9.0
>
> Attachments: SAMZA-473-0.patch
>
>
> The samza-serializers package should be removed, and its contents moved back
> into samza-core. Originally, the serializers package contained a JSON serde,
> and was isolated from samza-core to avoid introducing a Jackson dependency.
> However, Jackson was introduced as a dependency anyway. In addition, other
> serializers (e.g. an avro serializer, or a Protobuf serializer) should not
> reside in the same package (samza-serializers), but in their own packages
> (samza-avro, samza-protobuf) to avoid contaminating dependencies.
> In conclusion, this package is pointless, and should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
