[ 
https://issues.apache.org/jira/browse/SAMZA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221427#comment-14221427
 ] 

Chinmay Soman commented on SAMZA-473:
-------------------------------------

+1 .Patch compiles and ./gradlew check succeeds. 

Thanks !

> Remove samza-serializers package
> --------------------------------
>
>                 Key: SAMZA-473
>                 URL: https://issues.apache.org/jira/browse/SAMZA-473
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.9.0
>            Reporter: Chris Riccomini
>            Assignee: Chris Riccomini
>              Labels: newbie
>             Fix For: 0.9.0
>
>         Attachments: SAMZA-473-0.patch
>
>
> The samza-serializers package should be removed, and its contents moved back 
> into samza-core. Originally, the serializers package contained a JSON serde, 
> and was isolated from samza-core to avoid introducing a Jackson dependency. 
> However, Jackson was introduced as a dependency anyway. In addition, other 
> serializers (e.g. an avro serializer, or a Protobuf serializer)  should not 
> reside in the same package (samza-serializers), but in their own packages 
> (samza-avro, samza-protobuf) to avoid contaminating dependencies.
> In conclusion, this package is pointless, and should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to