TyrantLucifer commented on code in PR #4111:
URL:
https://github.com/apache/incubator-seatunnel/pull/4111#discussion_r1163482917
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/JsonUtils.java:
##########
@@ -233,15 +235,8 @@ public static String toJsonString(Object object) {
}
public static ObjectNode parseObject(String text) {
- try {
- if (text.isEmpty()) {
- return parseObject(text, ObjectNode.class);
- } else {
- return (ObjectNode) OBJECT_MAPPER.readTree(text);
- }
- } catch (Exception e) {
- throw new RuntimeException("String json deserialization
exception.", e);
- }
+ assert text != null;
Review Comment:
Do not use `assert` in codes, it only used in test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
