EricJoy2048 commented on code in PR #4923:
URL: https://github.com/apache/seatunnel/pull/4923#discussion_r1244636362


##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/config/MongodbSourceConfigProvider.java:
##########
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config;
+
+import org.apache.seatunnel.connectors.cdc.base.config.SourceConfig;
+import org.apache.seatunnel.connectors.cdc.base.config.StartupConfig;
+import org.apache.seatunnel.connectors.cdc.base.config.StopConfig;
+import org.apache.seatunnel.connectors.cdc.base.option.StartupMode;
+import org.apache.seatunnel.connectors.cdc.base.option.StopMode;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.exception.MongodbConnectorException;
+
+import org.jetbrains.annotations.Contract;
+import org.jetbrains.annotations.NotNull;
+
+import java.util.List;
+import java.util.Objects;
+
+import static 
org.apache.seatunnel.common.exception.CommonErrorCode.ILLEGAL_ARGUMENT;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.BATCH_SIZE;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.HEARTBEAT_INTERVAL_MILLIS;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.INCREMENTAL_SNAPSHOT_CHUNK_SIZE_MB;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.POLL_AWAIT_TIME_MILLIS;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.POLL_MAX_BATCH_SIZE;
+import static 
org.apache.seatunnel.shade.com.google.common.base.Preconditions.checkArgument;
+import static 
org.apache.seatunnel.shade.com.google.common.base.Preconditions.checkNotNull;
+
+public class MongodbSourceConfigProvider {
+
+    private MongodbSourceConfigProvider() {}
+
+    @NotNull @Contract(" -> new")
+    public static Builder newBuilder() {
+        return new Builder();
+    }
+
+    public static class Builder implements 
SourceConfig.Factory<MongodbSourceConfig> {
+        private String hosts;
+        private String username;
+        private String password;
+        private List<String> databaseList;
+        private List<String> collectionList;
+        private String connectionOptions;
+        private int batchSize = BATCH_SIZE.defaultValue();
+        private int pollAwaitTimeMillis = 
POLL_AWAIT_TIME_MILLIS.defaultValue();
+        private int pollMaxBatchSize = POLL_MAX_BATCH_SIZE.defaultValue();
+        private StartupConfig startupOptions;
+        private StopConfig stopOptions;
+        private int heartbeatIntervalMillis = 
HEARTBEAT_INTERVAL_MILLIS.defaultValue();
+        private int splitMetaGroupSize = 2;
+        private int splitSizeMB = 
INCREMENTAL_SNAPSHOT_CHUNK_SIZE_MB.defaultValue();
+
+        public Builder hosts(String hosts) {
+            this.hosts = hosts;
+            return this;
+        }
+
+        public Builder connectionOptions(String connectionOptions) {
+            this.connectionOptions = connectionOptions;
+            return this;
+        }
+
+        public Builder username(String username) {
+            this.username = username;
+            return this;
+        }
+
+        public Builder password(String password) {
+            this.password = password;
+            return this;
+        }
+
+        public Builder databaseList(List<String> databases) {
+            this.databaseList = databases;
+            return this;
+        }
+
+        public Builder collectionList(List<String> collections) {
+            this.collectionList = collections;
+            return this;
+        }
+
+        public Builder batchSize(int batchSize) {
+            checkArgument(batchSize >= 0);
+            this.batchSize = batchSize;
+            return this;
+        }
+
+        public Builder pollAwaitTimeMillis(int pollAwaitTimeMillis) {
+            checkArgument(pollAwaitTimeMillis > 0);
+            this.pollAwaitTimeMillis = pollAwaitTimeMillis;
+            return this;
+        }
+
+        public Builder pollMaxBatchSize(int pollMaxBatchSize) {
+            checkArgument(pollMaxBatchSize > 0);
+            this.pollMaxBatchSize = pollMaxBatchSize;
+            return this;
+        }
+
+        public Builder startupOptions(StartupConfig startupOptions) {
+            this.startupOptions = Objects.requireNonNull(startupOptions);
+            if (startupOptions.getStartupMode() != StartupMode.INITIAL
+                    && startupOptions.getStartupMode() != 
StartupMode.TIMESTAMP) {
+                throw new MongodbConnectorException(
+                        ILLEGAL_ARGUMENT,
+                        "Unsupported startup mode " + 
startupOptions.getStartupMode());
+            }
+            return this;
+        }
+
+        public Builder stopOptions(StopConfig stopOptions) {
+            this.stopOptions = Objects.requireNonNull(stopOptions);

Review Comment:
   Same as above.



##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/source/fetch/MongodbScanFetchTask.java:
##########
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.source.fetch;
+
+import 
org.apache.seatunnel.connectors.cdc.base.source.reader.external.FetchTask;
+import org.apache.seatunnel.connectors.cdc.base.source.split.IncrementalSplit;
+import org.apache.seatunnel.connectors.cdc.base.source.split.SnapshotSplit;
+import org.apache.seatunnel.connectors.cdc.base.source.split.SourceSplitBase;
+import 
org.apache.seatunnel.connectors.cdc.base.source.split.wartermark.WatermarkEvent;
+import 
org.apache.seatunnel.connectors.cdc.base.source.split.wartermark.WatermarkKind;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceConfig;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.exception.MongodbConnectorException;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.source.dialect.MongodbDialect;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.source.offset.ChangeStreamOffset;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbRecordUtils;
+
+import org.apache.kafka.connect.source.SourceRecord;
+
+import org.bson.BsonDocument;
+import org.bson.BsonInt64;
+import org.bson.BsonString;
+import org.bson.RawBsonDocument;
+import org.jetbrains.annotations.Contract;
+import org.jetbrains.annotations.NotNull;
+
+import com.mongodb.client.MongoClient;
+import com.mongodb.client.MongoCollection;
+import com.mongodb.client.MongoCursor;
+import io.debezium.connector.base.ChangeEventQueue;
+import io.debezium.pipeline.DataChangeEvent;
+import io.debezium.relational.TableId;
+import lombok.extern.slf4j.Slf4j;
+
+import java.util.ArrayList;
+import java.util.Collections;
+
+import static 
org.apache.seatunnel.common.exception.CommonErrorCode.ILLEGAL_ARGUMENT;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.COLL_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.DB_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.DOCUMENT_KEY;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.FULL_DOCUMENT;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.ID_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.NS_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.OPERATION_TYPE;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.OPERATION_TYPE_INSERT;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.SNAPSHOT_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.SNAPSHOT_TRUE;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.SOURCE_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.TS_MS_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbRecordUtils.createPartitionMap;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbRecordUtils.createSourceOffsetMap;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbRecordUtils.createWatermarkPartitionMap;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbUtils.createMongoClient;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbUtils.getMongoCollection;
+
+@Slf4j
+public class MongodbScanFetchTask implements FetchTask<SourceSplitBase> {
+
+    private final SnapshotSplit snapshotSplit;
+
+    private volatile boolean taskRunning = false;
+
+    public MongodbScanFetchTask(SnapshotSplit snapshotSplit) {
+        this.snapshotSplit = snapshotSplit;
+    }
+
+    @Override
+    public void execute(Context context) throws Exception {
+        MongodbFetchTaskContext taskContext = (MongodbFetchTaskContext) 
context;
+        MongodbSourceConfig sourceConfig = taskContext.getSourceConfig();
+        MongodbDialect dialect = taskContext.getDialect();
+        ChangeEventQueue<DataChangeEvent> changeEventQueue = 
taskContext.getQueue();
+        taskRunning = true;
+        TableId collectionId = snapshotSplit.getTableId();
+        final ChangeStreamOffset lowWatermark = 
dialect.displayCurrentOffset(sourceConfig);
+        log.info(
+                "Snapshot step 1 - Determining low watermark {} for split {}",
+                lowWatermark,
+                snapshotSplit);
+        changeEventQueue.enqueue(
+                new DataChangeEvent(
+                        WatermarkEvent.create(
+                                
createWatermarkPartitionMap(collectionId.identifier()),
+                                "__mongodb_watermarks",
+                                snapshotSplit.splitId(),
+                                WatermarkKind.LOW,
+                                lowWatermark)));
+
+        log.info("Snapshot step 2 - Snapshotting data");
+        try (MongoCursor<RawBsonDocument> cursor = 
getSnapshotCursor(snapshotSplit, sourceConfig)) {
+            while (cursor.hasNext()) {
+                checkTaskRunning();
+                BsonDocument valueDocument = 
normalizeSnapshotDocument(collectionId, cursor.next());
+                BsonDocument keyDocument = new BsonDocument(ID_FIELD, 
valueDocument.get(ID_FIELD));
+
+                SourceRecord snapshotRecord =
+                        buildSourceRecord(sourceConfig, collectionId, 
keyDocument, valueDocument);
+
+                changeEventQueue.enqueue(new DataChangeEvent(snapshotRecord));
+            }
+
+            ChangeStreamOffset highWatermark = 
dialect.displayCurrentOffset(sourceConfig);
+            log.info(
+                    "Snapshot step 3 - Determining high watermark {} for split 
{}",
+                    highWatermark,
+                    snapshotSplit);
+            changeEventQueue.enqueue(
+                    new DataChangeEvent(
+                            WatermarkEvent.create(
+                                    
createWatermarkPartitionMap(collectionId.identifier()),
+                                    "__mongodb_watermarks",
+                                    snapshotSplit.splitId(),
+                                    WatermarkKind.HIGH,
+                                    highWatermark)));
+
+            log.info(
+                    "Snapshot step 4 - Back fill stream split for snapshot 
split {}",
+                    snapshotSplit);
+            final IncrementalSplit dataBackfillSplit =
+                    createBackfillStreamSplit(lowWatermark, highWatermark);
+            final boolean streamBackfillRequired =
+                    
dataBackfillSplit.getStopOffset().isAfter(dataBackfillSplit.getStartupOffset());
+
+            if (!streamBackfillRequired) {
+                changeEventQueue.enqueue(
+                        new DataChangeEvent(
+                                WatermarkEvent.create(
+                                        
createWatermarkPartitionMap(collectionId.identifier()),
+                                        "__mongodb_watermarks",
+                                        dataBackfillSplit.splitId(),
+                                        WatermarkKind.END,
+                                        dataBackfillSplit.getStopOffset())));
+            } else {
+                MongodbStreamFetchTask dataBackfillTask =
+                        new MongodbStreamFetchTask(dataBackfillSplit);
+                dataBackfillTask.execute(taskContext);
+            }
+        } catch (Exception e) {
+            throw new MongodbConnectorException(
+                    ILLEGAL_ARGUMENT,
+                    String.format(
+                            "Execute snapshot read subtask for mongodb split 
%s fail",
+                            snapshotSplit));
+        } finally {
+            taskRunning = false;
+        }
+    }
+
+    @NotNull private MongoCursor<RawBsonDocument> getSnapshotCursor(
+            @NotNull SnapshotSplit snapshotSplit, MongodbSourceConfig 
sourceConfig) {
+        MongoClient mongoClient = createMongoClient(sourceConfig);
+        MongoCollection<RawBsonDocument> collection =
+                getMongoCollection(mongoClient, snapshotSplit.getTableId(), 
RawBsonDocument.class);
+        BsonDocument startKey = (BsonDocument) 
snapshotSplit.getSplitStart()[1];
+        BsonDocument endKey = (BsonDocument) snapshotSplit.getSplitEnd()[1];
+        BsonDocument hint = (BsonDocument) snapshotSplit.getSplitStart()[0];

Review Comment:
   Add log to log the `startKey, endKey ,hint` is better.



##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/source/fetch/MongodbScanFetchTask.java:
##########
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.source.fetch;
+
+import 
org.apache.seatunnel.connectors.cdc.base.source.reader.external.FetchTask;
+import org.apache.seatunnel.connectors.cdc.base.source.split.IncrementalSplit;
+import org.apache.seatunnel.connectors.cdc.base.source.split.SnapshotSplit;
+import org.apache.seatunnel.connectors.cdc.base.source.split.SourceSplitBase;
+import 
org.apache.seatunnel.connectors.cdc.base.source.split.wartermark.WatermarkEvent;
+import 
org.apache.seatunnel.connectors.cdc.base.source.split.wartermark.WatermarkKind;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceConfig;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.exception.MongodbConnectorException;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.source.dialect.MongodbDialect;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.source.offset.ChangeStreamOffset;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbRecordUtils;
+
+import org.apache.kafka.connect.source.SourceRecord;
+
+import org.bson.BsonDocument;
+import org.bson.BsonInt64;
+import org.bson.BsonString;
+import org.bson.RawBsonDocument;
+import org.jetbrains.annotations.Contract;
+import org.jetbrains.annotations.NotNull;
+
+import com.mongodb.client.MongoClient;
+import com.mongodb.client.MongoCollection;
+import com.mongodb.client.MongoCursor;
+import io.debezium.connector.base.ChangeEventQueue;
+import io.debezium.pipeline.DataChangeEvent;
+import io.debezium.relational.TableId;
+import lombok.extern.slf4j.Slf4j;
+
+import java.util.ArrayList;
+import java.util.Collections;
+
+import static 
org.apache.seatunnel.common.exception.CommonErrorCode.ILLEGAL_ARGUMENT;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.COLL_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.DB_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.DOCUMENT_KEY;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.FULL_DOCUMENT;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.ID_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.NS_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.OPERATION_TYPE;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.OPERATION_TYPE_INSERT;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.SNAPSHOT_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.SNAPSHOT_TRUE;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.SOURCE_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.TS_MS_FIELD;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbRecordUtils.createPartitionMap;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbRecordUtils.createSourceOffsetMap;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbRecordUtils.createWatermarkPartitionMap;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbUtils.createMongoClient;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.utils.MongodbUtils.getMongoCollection;
+
+@Slf4j
+public class MongodbScanFetchTask implements FetchTask<SourceSplitBase> {
+
+    private final SnapshotSplit snapshotSplit;
+
+    private volatile boolean taskRunning = false;
+
+    public MongodbScanFetchTask(SnapshotSplit snapshotSplit) {
+        this.snapshotSplit = snapshotSplit;
+    }
+
+    @Override
+    public void execute(Context context) throws Exception {
+        MongodbFetchTaskContext taskContext = (MongodbFetchTaskContext) 
context;
+        MongodbSourceConfig sourceConfig = taskContext.getSourceConfig();
+        MongodbDialect dialect = taskContext.getDialect();
+        ChangeEventQueue<DataChangeEvent> changeEventQueue = 
taskContext.getQueue();
+        taskRunning = true;
+        TableId collectionId = snapshotSplit.getTableId();
+        final ChangeStreamOffset lowWatermark = 
dialect.displayCurrentOffset(sourceConfig);
+        log.info(
+                "Snapshot step 1 - Determining low watermark {} for split {}",
+                lowWatermark,
+                snapshotSplit);
+        changeEventQueue.enqueue(
+                new DataChangeEvent(
+                        WatermarkEvent.create(
+                                
createWatermarkPartitionMap(collectionId.identifier()),
+                                "__mongodb_watermarks",
+                                snapshotSplit.splitId(),
+                                WatermarkKind.LOW,
+                                lowWatermark)));
+
+        log.info("Snapshot step 2 - Snapshotting data");
+        try (MongoCursor<RawBsonDocument> cursor = 
getSnapshotCursor(snapshotSplit, sourceConfig)) {
+            while (cursor.hasNext()) {
+                checkTaskRunning();
+                BsonDocument valueDocument = 
normalizeSnapshotDocument(collectionId, cursor.next());
+                BsonDocument keyDocument = new BsonDocument(ID_FIELD, 
valueDocument.get(ID_FIELD));
+
+                SourceRecord snapshotRecord =
+                        buildSourceRecord(sourceConfig, collectionId, 
keyDocument, valueDocument);
+
+                changeEventQueue.enqueue(new DataChangeEvent(snapshotRecord));
+            }
+
+            ChangeStreamOffset highWatermark = 
dialect.displayCurrentOffset(sourceConfig);
+            log.info(
+                    "Snapshot step 3 - Determining high watermark {} for split 
{}",
+                    highWatermark,
+                    snapshotSplit);
+            changeEventQueue.enqueue(
+                    new DataChangeEvent(
+                            WatermarkEvent.create(
+                                    
createWatermarkPartitionMap(collectionId.identifier()),
+                                    "__mongodb_watermarks",
+                                    snapshotSplit.splitId(),
+                                    WatermarkKind.HIGH,
+                                    highWatermark)));
+
+            log.info(
+                    "Snapshot step 4 - Back fill stream split for snapshot 
split {}",
+                    snapshotSplit);
+            final IncrementalSplit dataBackfillSplit =
+                    createBackfillStreamSplit(lowWatermark, highWatermark);
+            final boolean streamBackfillRequired =
+                    
dataBackfillSplit.getStopOffset().isAfter(dataBackfillSplit.getStartupOffset());
+
+            if (!streamBackfillRequired) {
+                changeEventQueue.enqueue(
+                        new DataChangeEvent(
+                                WatermarkEvent.create(
+                                        
createWatermarkPartitionMap(collectionId.identifier()),
+                                        "__mongodb_watermarks",
+                                        dataBackfillSplit.splitId(),
+                                        WatermarkKind.END,
+                                        dataBackfillSplit.getStopOffset())));
+            } else {
+                MongodbStreamFetchTask dataBackfillTask =
+                        new MongodbStreamFetchTask(dataBackfillSplit);
+                dataBackfillTask.execute(taskContext);
+            }
+        } catch (Exception e) {
+            throw new MongodbConnectorException(
+                    ILLEGAL_ARGUMENT,
+                    String.format(
+                            "Execute snapshot read subtask for mongodb split 
%s fail",
+                            snapshotSplit));
+        } finally {
+            taskRunning = false;
+        }
+    }
+
+    @NotNull private MongoCursor<RawBsonDocument> getSnapshotCursor(
+            @NotNull SnapshotSplit snapshotSplit, MongodbSourceConfig 
sourceConfig) {
+        MongoClient mongoClient = createMongoClient(sourceConfig);
+        MongoCollection<RawBsonDocument> collection =
+                getMongoCollection(mongoClient, snapshotSplit.getTableId(), 
RawBsonDocument.class);

Review Comment:
   Please add debug log to let us know which table split is being read .
   
   `LOG.debug("Snapshotting table {}", tableId);`



##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/config/MongodbSourceConfigProvider.java:
##########
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config;
+
+import org.apache.seatunnel.connectors.cdc.base.config.SourceConfig;
+import org.apache.seatunnel.connectors.cdc.base.config.StartupConfig;
+import org.apache.seatunnel.connectors.cdc.base.config.StopConfig;
+import org.apache.seatunnel.connectors.cdc.base.option.StartupMode;
+import org.apache.seatunnel.connectors.cdc.base.option.StopMode;
+import 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.exception.MongodbConnectorException;
+
+import org.jetbrains.annotations.Contract;
+import org.jetbrains.annotations.NotNull;
+
+import java.util.List;
+import java.util.Objects;
+
+import static 
org.apache.seatunnel.common.exception.CommonErrorCode.ILLEGAL_ARGUMENT;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.BATCH_SIZE;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.HEARTBEAT_INTERVAL_MILLIS;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.INCREMENTAL_SNAPSHOT_CHUNK_SIZE_MB;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.POLL_AWAIT_TIME_MILLIS;
+import static 
org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.config.MongodbSourceOptions.POLL_MAX_BATCH_SIZE;
+import static 
org.apache.seatunnel.shade.com.google.common.base.Preconditions.checkArgument;
+import static 
org.apache.seatunnel.shade.com.google.common.base.Preconditions.checkNotNull;
+
+public class MongodbSourceConfigProvider {
+
+    private MongodbSourceConfigProvider() {}
+
+    @NotNull @Contract(" -> new")
+    public static Builder newBuilder() {
+        return new Builder();
+    }
+
+    public static class Builder implements 
SourceConfig.Factory<MongodbSourceConfig> {
+        private String hosts;
+        private String username;
+        private String password;
+        private List<String> databaseList;
+        private List<String> collectionList;
+        private String connectionOptions;
+        private int batchSize = BATCH_SIZE.defaultValue();
+        private int pollAwaitTimeMillis = 
POLL_AWAIT_TIME_MILLIS.defaultValue();
+        private int pollMaxBatchSize = POLL_MAX_BATCH_SIZE.defaultValue();
+        private StartupConfig startupOptions;
+        private StopConfig stopOptions;
+        private int heartbeatIntervalMillis = 
HEARTBEAT_INTERVAL_MILLIS.defaultValue();
+        private int splitMetaGroupSize = 2;
+        private int splitSizeMB = 
INCREMENTAL_SNAPSHOT_CHUNK_SIZE_MB.defaultValue();
+
+        public Builder hosts(String hosts) {
+            this.hosts = hosts;
+            return this;
+        }
+
+        public Builder connectionOptions(String connectionOptions) {
+            this.connectionOptions = connectionOptions;
+            return this;
+        }
+
+        public Builder username(String username) {
+            this.username = username;
+            return this;
+        }
+
+        public Builder password(String password) {
+            this.password = password;
+            return this;
+        }
+
+        public Builder databaseList(List<String> databases) {
+            this.databaseList = databases;
+            return this;
+        }
+
+        public Builder collectionList(List<String> collections) {
+            this.collectionList = collections;
+            return this;
+        }
+
+        public Builder batchSize(int batchSize) {
+            checkArgument(batchSize >= 0);
+            this.batchSize = batchSize;
+            return this;
+        }
+
+        public Builder pollAwaitTimeMillis(int pollAwaitTimeMillis) {
+            checkArgument(pollAwaitTimeMillis > 0);
+            this.pollAwaitTimeMillis = pollAwaitTimeMillis;
+            return this;
+        }
+
+        public Builder pollMaxBatchSize(int pollMaxBatchSize) {
+            checkArgument(pollMaxBatchSize > 0);
+            this.pollMaxBatchSize = pollMaxBatchSize;
+            return this;
+        }
+
+        public Builder startupOptions(StartupConfig startupOptions) {
+            this.startupOptions = Objects.requireNonNull(startupOptions);
+            if (startupOptions.getStartupMode() != StartupMode.INITIAL

Review Comment:
   Do you lost this option in the document?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to